New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roles: add role for removing stale LUN #320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnecas
requested changes
Jul 28, 2021
mnecas
reviewed
Jul 28, 2021
vjuranek
force-pushed
the
BZ1966873
branch
2 times, most recently
from
July 29, 2021 08:33
58d698b
to
487b438
Compare
verified with one multipath path and several multipath paths |
mnecas
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mwperina
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
mnecas
requested changes
Aug 9, 2021
Convert existing example for removing mpath device into the role. This role is intended for removing stale LUN from the hosts in given data center. For provided data center name and LUN WWID, the role will collect hosts attached to this data center and will remove provided LUN from all these hosts. Existing example is removed as it's replaced by this role. Bug-Url: https://bugzilla.redhat.com/1966873
mnecas
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert existing example for removing mpath device into the role.
This role is intended for removing stale LUN from the hosts in given
data center. For provided data center name and LUN WWID, the role will
collect hosts attached to this data center and will remove provided LUN
from all these hosts.
Existing example is removed as it's replaced by this role.
Bug-Url: https://bugzilla.redhat.com/1966873