ovirt_disk: fix activate #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm that it worked for me, both directly using ansible-playbook command from a CentOS 7.8 controller node with ansible-2.9.9-1.el7.noarch, after patching /usr/lib/python2.7/site-packages/ansible/modules/cloud/ovirt/ovirt_disk.py and also using job template in an AWX environment with ansible 2.8.5 after patching the same way the custom venv file /opt/my-envs/py36/lib/python3.6/site-packages/ansible/modules/cloud/ovirt/ovirt_disk.py. I put a pause of 10 seconds between attach task (with actvate: no) and activation task and I have the time to see in web admin gui the disk first attached with the still red arrow and then becoming green. Thanks for the quick fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: was not able to attach the deactivated disk to the VM
This keeps previous logic the same (default is activated) but when specifying the value it will overwrite it.
@mwperina @dangel101