Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution environment metadata #91

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

AlanCoding
Copy link
Contributor

This adds data to allow users to add ovirt.ovirt to a new thing called Execution Environments in a way that makes its content usable.

Some specifics of the expected contract are laid out in the project https://github.com/ansible/ansible-builder, this is a CLI tool which will take collections inside a user's definition and spit out a container image. This image can then be used in executors using ansible-runner.

Since this collection is a part of the inventory options in AWX and Ansible Tower, this collection is a part of our base test case. Some initial smoke test to assure that the HAS_ variable from module_utils will come out to be True:

$ docker run --rm --tty --interactive exec-env-pycurl python3 -c "import ovirtsdk4.version as sdk_version; print(sdk_version.VERSION)"
4.4.4

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@AlanCoding
Copy link
Contributor Author

ci test please

@mnecas
Copy link
Member

mnecas commented Aug 21, 2020

ci test please

@mnecas mnecas merged commit e7c6da3 into oVirt:master Aug 21, 2020
mnecas added a commit to mnecas/ovirt-ansible-collection that referenced this pull request Sep 10, 2020
mnecas added a commit that referenced this pull request Sep 10, 2020
* migrate #87 from engine-setup

* migrate #88 from engine-setup

* migrate #91 from engine-setup

* add blank line to defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants