Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PostgreSQL JDBC driver #9

Closed
wants to merge 1 commit into from
Closed

Add PostgreSQL JDBC driver #9

wants to merge 1 commit into from

Conversation

mwperina
Copy link
Member

Adds PostgreSQL JDBC driver due to recent regression by PostgreSQL JDBC
drivers > 42.2.10

Bug-Url: https://bugzilla.redhat.com/2077794
Signed-off-by: Martin Perina mperina@redhat.com

@mwperina mwperina requested a review from arso as a code owner April 27, 2022 07:17
sandrobonazzola
sandrobonazzola requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @dupondje comment

@sandrobonazzola sandrobonazzola added this to the ovirt-4.5.0-1 milestone Apr 27, 2022
arso
arso suggested changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@arso arso left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a typo in spec 'posttgresql' .
I was only a bit surprised that xmvn did not complain about missing parent pom ... perhaps it's already shipped with different package?

EDIT: actually it did complain.
Unable to resolve parent POM org.postgresql:pgjdbc-core-parent:pom:1.1

These 2 parent poms need to be added under %install and above postgresqljdbc:
%mvn_artifact dependencies/org/postgresql/pgjdbc-versions/1.1.6/pgjdbc-versions-1.1.6.pom
%mvn_artifact dependencies/org/postgresql/pgjdbc-core-parent/1.1.6/pgjdbc-core-parent-1.1.6.pom

ovirt-dependencies.spec.in Outdated Show resolved Hide resolved
arso
arso reviewed Apr 27, 2022
View reviewed changes
ovirt-dependencies.spec.in Outdated Show resolved Hide resolved
@arso
Copy link
Contributor

arso commented Apr 27, 2022 •
edited

I have pushed updates (I've made them for the review anyway)

@mwperina @arso
Add PostgreSQL JDBC driver
9fb7f2d 
Adds PostgreSQL JDBC driver due to recent regression by PostgreSQL JDBC
drivers > 42.2.10

Bug-Url: https://bugzilla.redhat.com/2077794
Signed-off-by: Martin Perina <mperina@redhat.com>
sandrobonazzola
sandrobonazzola approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina
Copy link
Member Author

I'd wait with merging till Monday, we should know if this workaround is needed or we will have better solution

@mwperina
Copy link
Member Author

Closing in favor of oVirt/ovirt-engine#322 and #10

@mwperina mwperina closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupondje dupondje dupondje left review comments

@arso arso arso approved these changes

@sandrobonazzola sandrobonazzola sandrobonazzola approved these changes

Assignees

@mwperina mwperina

Labels
None yet
Projects
None yet
Milestone
ovirt-4.5.0-1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mwperina @arso @dupondje @sandrobonazzola