Reconfigure SSO on keycloak activation #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arso
force-pushed
the
fix_sso_on_keycloak_activation
branch
from
7bce519
to
96ef17c
Compare
mwperina
reviewed
May 19, 2022
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-grafana-dwh/core/config.py
Show resolved
Hide resolved
arso
force-pushed
the
fix_sso_on_keycloak_activation
branch
3 times, most recently
from
bbfa681
to
7576a8d
Compare
This patch makes sure that ovirt oauth sso configuration in `/etc/grafana/grafana.ini` gets updated to use ovirt engine internal keycloak. This feature originally was only supporting new installations, now it allows to enable keycloak on existing ovirt engine installations and setups grafana to make use of ovirt internal sso.
arso
force-pushed
the
fix_sso_on_keycloak_activation
branch
from
7576a8d
to
d5ba09b
Compare
|
Please see the description of recent changes that I posted there oVirt/ovirt-engine#379 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes sure that ovirt oauth sso configuration in
/etc/grafana/grafana.inigets updated to use ovirt engine internalkeycloak.
This feature originally was only supporting new installations, now it
allows to enable keycloak on existing ovirt engine installations and
setups grafana to make use of ovirt internal sso.
This patch should be merged alongside with: