Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: setup: Fix the call to ok_to_renew_cert #48

Merged
merged 2 commits into from
Aug 25, 2022

Commits on Aug 23, 2022

  1. packaging: setup: Fix the call to ok_to_renew_cert

    ok_to_renew_cert now requires two more parameters - "short_life", which
    tells whether the cert's life should be (relatively) short (e.g. for a
    web server) or can be long (e.g. for engine<->hosts communications), and
    "environment", which is used to check the value of
    CertExpirationWarnPeriodInDays (the "long" life one).
    
    Please note, that the use, there, of environment[ENGINE_DB_ENV_KEYS],
    breaks us if grafana is set up separately from both the engine and dwh.
    The documentation currently tells to configure grafana either on the
    engine machine or on the dwh machine (if they are separate), but nothing
    thus far prevented configuring it on a third machine. This will now
    break.
    
    Change-Id: I274917c7452c42bc3f3f05446677154852f847e1
    Signed-off-by: Yedidyah Bar David <didi@redhat.com>
    didib committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    14afbe0 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Configuration menu
    Copy the full SHA
    25d813f View commit details
    Browse the repository at this point in the history