Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce host CPU units details #20

Merged
merged 1 commit into from Mar 14, 2022
Merged

Introduce host CPU units details #20

merged 1 commit into from Mar 14, 2022

Conversation

ljelinkova
Copy link
Collaborator

@ljelinkova ljelinkova commented Feb 17, 2022 •
edited

Introduce the possibility to retrieve the list of the host's physical CPUs with the current pinning status.

oliel
oliel approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@oliel oliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ahadas
ahadas reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@ahadas ahadas left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes a lot of sense to return it as part of a sub-endpoint of a host so overall it looks good

src/main/java/types/HostCpuPinning.java Outdated Show resolved Hide resolved
src/main/java/types/Host.java Outdated Show resolved Hide resolved
src/main/java/types/Host.java Show resolved Hide resolved
@ljelinkova ljelinkova force-pushed the cpu-topology branch 2 times, most recently from ce08084 to a8188c8 Compare March 1, 2022 12:03
ahadas
ahadas approved these changes Mar 1, 2022
View reviewed changes
src/main/java/types/Host.java Outdated Show resolved Hide resolved
@ljelinkova
Introduce host CPU unit details
8d368fc 
Introduce the possibility to retrieve the list of the host's physical CPUs with the current pinning status.
@ljelinkova ljelinkova changed the title Introduce host CPU pinning details Introduce host CPU units details Mar 8, 2022
@ahadas ahadas requested review from mwperina and oliel March 10, 2022 07:42
@oliel oliel merged commit fd82d55 into oVirt:master Mar 14, 2022
@ljelinkova ljelinkova deleted the cpu-topology branch April 1, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

@liranr23 liranr23 liranr23 approved these changes

@oliel oliel oliel approved these changes

@mwperina mwperina Awaiting requested review from mwperina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ljelinkova @ahadas @liranr23 @oliel