Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation to SystemOptionService #79

Merged
merged 4 commits into from Jul 18, 2022

Conversation

smelamud
Copy link
Member

Documentation to SystemOptionService is changed to use MigrationPolicies
option as an example instead of non-existing MigrationPoliciesSupported
option.

Change-Id: Ie0c2eadf855758b522f39b35bd756c943701d024
Signed-off-by: Shmuel Melamud smelamud@redhat.com

@smelamud smelamud requested a review from oliel as a code owner July 12, 2022 11:52
@smelamud smelamud requested a review from ahadas July 12, 2022 11:52
@smelamud smelamud self-assigned this Jul 12, 2022
Documentation to SystemOptionService is changed to use MigrationPolicies
option as an example instead of non-existing MigrationPoliciesSupported
option.

Change-Id: Ie0c2eadf855758b522f39b35bd756c943701d024
Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1974974
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good but in order to address the issue in the bug we should also state that the ID of a migration policy that is returned for a cluster/vm cannot be queried but instead users should be able to find it using this MigrationPolicies endpoint

Added note to VmBase.migration() and Cluster.migration() documentation
recommending to use MigrationPolicies endpoint for querying a migration
policy by its ID.

Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1974974

Change-Id: If47717c208b17d2b9de86a1cebb2cec16264b9e6
@smelamud
Copy link
Member Author

@ahadas Done.

@oliel oliel merged commit 07262f4 into oVirt:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants