Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated and removed rb_cData with rb_cObject #3

Merged
merged 1 commit into from Sep 19, 2022

Conversation

jjlimepoint
Copy link
Contributor

This enables the gem to work on ruby 3.1.0 and higher - without this, you get invalid symbols when attempting to build on ruby 3.1. I've tested this also on ruby 2.7, where it does work.

@jjlimepoint
Copy link
Contributor Author

Hi,

Was just wondering if there is something I can do on my end to help move this along?

Thanks in advance either way!

Copy link
Contributor

@santos1709 santos1709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santos1709 santos1709 merged commit 97df88c into oVirt:master Sep 19, 2022
@caiobsilva caiobsilva mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants