Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows VM with TPM cannot be exported to a data domain #702

Open
mz-pdm opened this issue Oct 5, 2022 · 0 comments
Open

Windows VM with TPM cannot be exported to a data domain #702

mz-pdm opened this issue Oct 5, 2022 · 0 comments
Labels
bug virt

Comments

@mz-pdm
Copy link
Member

mz-pdm commented Oct 5, 2022

An attempt to export such a VM fails immediately with "Export VM Failed. Cannot add VM. TPM device is required by the guest OS".
Export of a non-Windows VM with TPM works fine.
@mz-pdm mz-pdm self-assigned this Oct 6, 2022
mz-pdm added a commit to mz-pdm/ovirt-engine that referenced this issue Oct 6, 2022
@mz-pdm
core: When adding a VM, look for TPM also in the original VM
f2fbd86 
At least when exporting a VM to a data domain, isTpmEnabled parameter
is always null, which makes all the related checks here confused.  For
instance, when exporting a Windows VM with a mandatory TPM device, the
export is rejected because TPM is not found in the parameters although
TPM is actually present in the original VM.  A non-Windows VM with TPM
can be successfully exported, including TPM, but the checks here are
not valid due to the missing parameter.

Bug-Url: oVirt#702
mz-pdm added a commit to mz-pdm/ovirt-engine that referenced this issue Oct 19, 2022
@mz-pdm
core: When adding a VM, look for TPM also in the original VM
124b95c 
At least when exporting a VM to a data domain, isTpmEnabled parameter
is always null, which makes all the related checks here confused.  For
instance, when exporting a Windows VM with a mandatory TPM device, the
export is rejected because TPM is not found in the parameters although
TPM is actually present in the original VM.  A non-Windows VM with TPM
can be successfully exported, including TPM, but the checks here are
not valid due to the missing parameter.

Bug-Url: oVirt#702
mz-pdm added a commit to mz-pdm/ovirt-engine that referenced this issue Oct 25, 2022
@mz-pdm
frontend: Add TPM parameter when cloning a VM from a snapshot
8cbfd42 
When cloning a VM from a snapshot, isTpmEnabled parameter is not set
in VmSnapshotListModel, resulting in a loss of the TPM device and an
error if the TPM device is mandatory, i.e. for VMs with newer Windows
versions as the guest OS.  This patch fixes the omission and adds the
corresponding parameter.

Bug-Url: oVirt#702
Bug-Url: https://bugzilla.redhat.com/2136180
mz-pdm added a commit to mz-pdm/ovirt-engine that referenced this issue Oct 25, 2022
@mz-pdm
core: Update TPM device in parameters
138949c 
TPM device is not updated in
VmDeviceUtils.updateVmDevicesInParameters.  This results in omitting
the TPM device at least when exporting a VM to a data domain and an
error when the TPM device is mandatory, i.e. for VMs with a modern
Windows guest OS.  This patch fixes the omission and sets the
corresponding parameter.

Bug-Url: oVirt#702
ljelinkova pushed a commit that referenced this issue Nov 1, 2022
@mz-pdm @ljelinkova
frontend: Add TPM parameter when cloning a VM from a snapshot
69be664 
When cloning a VM from a snapshot, isTpmEnabled parameter is not set
in VmSnapshotListModel, resulting in a loss of the TPM device and an
error if the TPM device is mandatory, i.e. for VMs with newer Windows
versions as the guest OS.  This patch fixes the omission and adds the
corresponding parameter.

Bug-Url: #702
Bug-Url: https://bugzilla.redhat.com/2136180
ljelinkova pushed a commit that referenced this issue Nov 1, 2022
@mz-pdm @ljelinkova
core: Update TPM device in parameters
7e40ad3 
TPM device is not updated in
VmDeviceUtils.updateVmDevicesInParameters.  This results in omitting
the TPM device at least when exporting a VM to a data domain and an
error when the TPM device is mandatory, i.e. for VMs with a modern
Windows guest OS.  This patch fixes the omission and sets the
corresponding parameter.

Bug-Url: #702
mwperina pushed a commit to mwperina/ovirt-engine that referenced this issue Nov 2, 2022
@mz-pdm @mwperina
frontend: Add TPM parameter when cloning a VM from a snapshot
60e069d 
When cloning a VM from a snapshot, isTpmEnabled parameter is not set
in VmSnapshotListModel, resulting in a loss of the TPM device and an
error if the TPM device is mandatory, i.e. for VMs with newer Windows
versions as the guest OS.  This patch fixes the omission and adds the
corresponding parameter.

Bug-Url: oVirt#702
Bug-Url: https://bugzilla.redhat.com/2136180
mwperina pushed a commit to mwperina/ovirt-engine that referenced this issue Nov 2, 2022
@mz-pdm @mwperina
core: Update TPM device in parameters
cff4010 
TPM device is not updated in
VmDeviceUtils.updateVmDevicesInParameters.  This results in omitting
the TPM device at least when exporting a VM to a data domain and an
error when the TPM device is mandatory, i.e. for VMs with a modern
Windows guest OS.  This patch fixes the omission and sets the
corresponding parameter.

Bug-Url: oVirt#702
ahadas pushed a commit that referenced this issue Nov 2, 2022
@mz-pdm @ahadas
frontend: Add TPM parameter when cloning a VM from a snapshot
a7633b7 
When cloning a VM from a snapshot, isTpmEnabled parameter is not set
in VmSnapshotListModel, resulting in a loss of the TPM device and an
error if the TPM device is mandatory, i.e. for VMs with newer Windows
versions as the guest OS.  This patch fixes the omission and adds the
corresponding parameter.

Bug-Url: #702
Bug-Url: https://bugzilla.redhat.com/2136180
ahadas pushed a commit that referenced this issue Nov 2, 2022
@mz-pdm @ahadas
core: Update TPM device in parameters
0089bdf 
TPM device is not updated in
VmDeviceUtils.updateVmDevicesInParameters.  This results in omitting
the TPM device at least when exporting a VM to a data domain and an
error when the TPM device is mandatory, i.e. for VMs with a modern
Windows guest OS.  This patch fixes the omission and sets the
corresponding parameter.

Bug-Url: #702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug virt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mz-pdm