New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: consider offline cpus for dedicated #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
March 8, 2022 09:46
/ost |
/ost network-suite-master |
ahadas
reviewed
Mar 13, 2022
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
ahadas
requested changes
Mar 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented on code that I assume would not change soon, let's change that, get this in and continue with changing that allocation logic
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
/ost |
ljelinkova
approved these changes
Mar 14, 2022
This patch will change the pinning logic for dedicated CPUs feature. Until now we didn't consider the option where one or more CPUs can be offline on the host. Change-Id: Ic8a0155047450baddad3ab65943c8c4508c8f5e7 Bug-Url: https://bugzilla.redhat.com/1782077 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
/ost |
ahadas
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will change the pinning logic for dedicated CPUs feature.
Until now we didn't consider the option where one or more CPUs can be
offline on the host.
Change-Id: Ic8a0155047450baddad3ab65943c8c4508c8f5e7
Bug-Url: https://bugzilla.redhat.com/1782077
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com