core: fix resize and pin scheduling #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
ahadas
reviewed
Mar 13, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Outdated
Show resolved
Hide resolved
...bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnit.java
Show resolved
Hide resolved
liranr23
force-pushed
the
dedicated_fixes
branch
from
02795a7
to
8f1345b
Compare
ljelinkova
approved these changes
Mar 14, 2022
When running a Resize and Pin NUMA VM, the validation thinks the CPU pinning already set. But that is incorrect for this flow. It is set only in the last phase on running the VM. The validation results in an NPE in such case. Change-Id: I83cf61d8b5f82187222ca0f2ee5085dde97452c6 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
liranr23
force-pushed
the
dedicated_fixes
branch
from
8f1345b
to
7d1b01d
Compare
|
Fixes BZ 2062754 |
ahadas
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a Resize and Pin NUMA VM, the validation thinks the CPU
pinning already set. But that is incorrect for this flow. It is set only
in the last phase on running the VM. The validation results in an NPE in
such case.
Fixes BZ 2062754
Change-Id: I83cf61d8b5f82187222ca0f2ee5085dde97452c6
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com