Disable dedicated cpu pinning policy for vms with pinned numa nodes #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljelinkova
requested review from
sgratch,
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
ljelinkova
requested review from
liranr23 and
ahadas
and removed request for
bennyz,
didib,
ahadas,
emesika,
mwperina,
michalskrivanek,
sgratch and
oliel
ljelinkova
force-pushed
the
numa-dedicated
branch
from
30a7b8d
to
6fe7883
Compare
ahadas
reviewed
Mar 15, 2022
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
...odules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Show resolved
Hide resolved
ljelinkova
force-pushed
the
numa-dedicated
branch
from
6fe7883
to
5b5e322
Compare
liranr23
reviewed
Mar 15, 2022
...dmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
Outdated
Show resolved
Hide resolved
ljelinkova
force-pushed
the
numa-dedicated
branch
2 times, most recently
from
9237082
to
d62206e
Compare
ahadas
approved these changes
Mar 24, 2022
|
@ljelinkova there are some failures in UICommonWeb, can you please check them out? |
ljelinkova
force-pushed
the
numa-dedicated
branch
from
a3ecb61
to
382f771
Compare
|
/ost |
When using the dedicated cpu policy for vms with numa enabled, the policy will pin the numa nodes automatically. That is why the policy is disabled if the user has already pinned the numa nodes.
liranr23
approved these changes
Mar 27, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the dedicated cpu policy for vms with numa enabled, the policy will pin the numa nodes automatically. That is why the policy is disabled if the user has already pinned the numa nodes.