core: Fix removal of unmanaged network with long name #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The long name networks are represented on the host as onUUID. When the network is unmanaged and the attachment is gone we need to remove network based on it's vdsm name and not the name that it had in engine. Use vdsmName for removal of unmanaged interfaces instead of the engine name. Signed-off-by: Ales Musil <amusil@redhat.com> Bug-Url: https://bugzilla.redhat.com/2070053
almusil
force-pushed
the
fix_removal_of_long_name_net
branch
from
328b8aa
to
cae641d
Compare
|
/ost |
1 similar comment
|
/ost |
erav
approved these changes
Mar 31, 2022
|
/ost basic-suite-master rhel8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long name networks are represented on the host as onUUID.
When the network is unmanaged and the attachment is gone we need
to remove network based on it's vdsm name and not the name
that it had in engine. Use vdsmName for removal of unmanaged
interfaces instead of the engine name.
Signed-off-by: Ales Musil amusil@redhat.com