fix FIPS handling #255
Merged
fix FIPS handling #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
requested review from
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
ahadas
requested review from
liranr23
and removed request for
bennyz,
didib,
emesika,
mwperina,
michalskrivanek,
sgratch and
oliel
|
/ost |
liranr23
reviewed
Apr 11, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Outdated
Show resolved
Hide resolved
I didn't get to the bottom of that - but this certainly didn't help |
The idea behind using VdsEventListener is to propagate events at the vdsbroker layer to the bll layer. Now that the trigger to initiate HandleVdsFips is InitVdsOnUp, we no longer need it. Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Now that we check the host FIPS mode (compared to the cluster's mode) in InitVdsOnUp, we need to take special care about the VDS object we check since InitVdsOnUp is called before persisting the data that is received by the host monitoring. So instead of passing the reported data to HandleVdsFips, it would be simpler to inline HandleVdsFips into InitVdsOnUp - we have everything accessible there and we can reuse some existing code to set the non-operational mode, if needed. Bug-Url: https://bugzilla.redhat.com/2065543 Signed-off-by: Arik Hadas <ahadas@redhat.com>
Also do that before initialize the storage domains as checking the FIPS mode compared to the cluster's mode is much simpler. Signed-off-by: Arik Hadas <ahadas@redhat.com>
liranr23
approved these changes
Apr 11, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we check the host FIPS mode (compared to the cluster's mode) in InitVdsOnUp, we need to take special care about the VDS object we check since InitVdsOnUp is called before persisting the data that is received by the host monitoring. So instead of passing the reported data to HandleVdsFips, it is simpler to inline HandleVdsFips into InitVdsOnUp - we have everything accessible there and we can reuse some existing code to set the non-operational mode, if needed.
Bug-Url: https://bugzilla.redhat.com/2065543