Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine_setup: cleanup after ARS removal #257

Merged
merged 3 commits into from Apr 18, 2022
Merged

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Apr 11, 2022

Removal of ansible-runner-service constants from engine_setup.

@mnecas mnecas force-pushed the ARS_cleanup branch 4 times, most recently from e91ebc1 to 478a053 Compare April 14, 2022 08:50
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix python linter issues, other than that it looks good to me

@mnecas
Copy link
Member Author

mnecas commented Apr 14, 2022

Fixed

@@ -0,0 +1,86 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to ars_cleanup.py to clear mentioned it's related to ansible-runner-service and not ansible-runner

#


"""Apache ansible-runner plugin."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache ansible-runner-service cleanup plugin


@util.export
class Plugin(plugin.PluginBase):
"""Cleanup of the ansible-runner plugin."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache ansible-runner-service cleanup plugin

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina
Copy link
Member

/ost

@mwperina mwperina merged commit 50dfc9a into oVirt:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants