core: reverse snapshots list #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs extensive testing as this is a very high risk area |
|
/ost |
ahadas
reviewed
Apr 13, 2022
...odules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
Show resolved
Hide resolved
bennyz
force-pushed
the
disk-snapshot-remove
branch
from
49daa89
to
b01fa58
Compare
|
/ost |
ahadas
approved these changes
Apr 18, 2022
bennyz
force-pushed
the
disk-snapshot-remove
branch
from
b01fa58
to
32bce6b
Compare
Currently, when removing individual disk snapshots, they are grouped by their respective disk_id and are removed together, in the order from the parent to the child. For example: A <- S2 <- S1 And we select disks from S1 and S2, S1 will be removed first and then S2. However, since block commit was introduced, we only do forward merges, meaning when removing S1, the child S2, will be the one removed after its contents are merged into S1. So when the operation attempts to merge S2, it will no longer exist. This patch fixes the issue by reversing the order of images to start the operation the other way around. Bug-Url: https://bugzilla.redhat.com/2070451 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
disk-snapshot-remove
branch
from
32bce6b
to
57bf4d6
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when removing individual disk snapshots, they are grouped
by their respective disk_id and are removed together, in the order from
the parent to the child. For example:
A <- S2 <- S1
And we select disks from S1 and S2, S1 will be removed first and then
S2. However, since block commit was introduced, we only do forward
merges, meaning when removing S1, the child S2, will be the one removed
after its contents are merged into S1. So when the operation attempts to
merge S2, it will no longer exist.
This patch fixes the issue by reversing the order of images to start the
operation the other way around.
Bug-Url: https://bugzilla.redhat.com/2070451