core: always update volume size when creating a new image #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ost |
1 similar comment
|
/ost |
ahadas
reviewed
Apr 18, 2022
...odules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java
Outdated
Show resolved
Hide resolved
Since we have the disk_content_type field we can use it to distinguish between the two memory related disks instead of checking the size. Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
|
/ost |
Vdsm often aligns the size of the volume when creating, and the volume will end up having a different size in the engine than what is on the storage. This is already handled when a new disk is created but not when a new snapshot is created. Since there is already a getVolumeInfo request at the end of snapshot creation, we can use this opportunity to update the size of the volume as well. Bug-Url: https://bugzilla.redhat.com/1852308 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
requested review from
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
ahadas
approved these changes
May 18, 2022
|
/ost |
1 similar comment
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vdsm often aligns the size of the volume when creating, and the volume
will end up having a different size in the engine than what is on the
storage. This is already handled when a new disk is created but not when
a new snapshot is created.
Since there is already a getVolumeInfo request at the end of snapshot
creation, we can use this opportunity to update the size of the volume
as well.
Bug-Url: https://bugzilla.redhat.com/1852308