core: handle missing allocation policy/format when converting #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If allocation policy or format were not passed to the disk conversion endpoint it will fail to setup monitoring because of NPE. This patch uses the existing allocation policy or format when it's missing to generate the message. Bug-Url: https://bugzilla.redhat.com/2076042 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
fix-null-convert
branch
from
134daa3
to
3e2f31a
Compare
ahadas
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If allocation policy or format were not passed to the disk conversion endpoint it will fail to setup monitoring because of NPE.
This patch uses the existing allocation policy or format when it's missing to generate the message.