restapi: fix hrefs in single GET disksnapshot request #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkemel
force-pushed
the
fix_get_disk_snapshot
branch
from
2e241af
to
3841e2d
Compare
|
/ost |
ahadas
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
this looked familiar - but the change I did involved a similar change related to vm snapshots (querying a specific one rather than going through all the vm snapshots) and not to disk snapshots
it looks correct, I'd separate out the settings of href to a different commit but as this is a small PR, that's fine
mkemel
force-pushed
the
fix_get_disk_snapshot
branch
from
3841e2d
to
ddf4781
Compare
|
Rebased |
sleviim
reviewed
Apr 18, 2022
...i/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskSnapshotResource.java
Show resolved
Hide resolved
mkemel
force-pushed
the
fix_get_disk_snapshot
branch
from
ddf4781
to
35a28fa
Compare
|
Moving the query change to a separate patch, this PR now handles only the href fix |
mkemel
changed the title
mkemel
force-pushed
the
fix_get_disk_snapshot
branch
from
35a28fa
to
34c53d3
Compare
sleviim
approved these changes
Apr 19, 2022
mkemel
force-pushed
the
fix_get_disk_snapshot
branch
from
34c53d3
to
e81394e
Compare
emesika
approved these changes
Apr 20, 2022
|
/ost |
mkemel
force-pushed
the
fix_get_disk_snapshot
branch
from
e81394e
to
688e3ab
Compare
sleviim
approved these changes
Apr 20, 2022
Fixing GET api/disks/{diskid}/disksnapshots/{snapshotid}:
Correct href for <parent> and <disk> elements.
1. <disk> element was returned without href attribute
2. <parent> element had an incorrect href - buildParentHref() was
used, although the element is not related to the parent entity
resource, but rather represents the parent image of the snapshot.
Bug-Url: https://bugzilla.redhat.com/2013697
ahadas
force-pushed
the
fix_get_disk_snapshot
branch
from
688e3ab
to
0422d91
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing GET api/disks/{diskid}/disksnapshots/{snapshotid}:
Correct href for and elements.
<disk>element was returned without href attribute<parent>element had an incorrect href - buildParentHref() wasused, although the element is not related to the parent entity
resource, but rather represents the parent image of the snapshot.