restapi: prefer parentType over subclasses in getParent #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
requested review from
oliel,
mwperina,
ahadas,
emesika,
michalskrivanek,
sgratch and
didib
as code owners
bennyz
force-pushed
the
use-suggested-parent
branch
from
177fe3f
to
762221c
Compare
ahadas
reviewed
May 1, 2022
...anager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java
Outdated
Show resolved
Hide resolved
...anager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java
Outdated
Show resolved
Hide resolved
oliel
approved these changes
May 2, 2022
|
Consider Arik's suggestions for name changes, I don't feel strongly about any of them, but in general this solution LGTM, approved |
Currently LinkHelper#getParent may return subclasses even if the parentType exists in the methods list. This makes the returned resource unpredicatble as the method list does not have any guaranteed order. To fix this, this patch tries to match parentType first, and only if it is not in the list it will fallback to a subclass. Bug-Url: https://bugzilla.redhat.com/2080728 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
use-suggested-parent
branch
from
762221c
to
5416638
Compare
|
/ost |
|
OST failed on UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently LinkHelper#getParent may return subclasses even if the parentType exists in the methods list. This makes the returned resource unpredictable as the method list does not have any guaranteed order.
To fix this, this patch tries to match parentType first, and only if it is not in the list it will fallback to a subclass.
In the bug the parent is
Vm, but sinceBackupalso has a reference to theSnapshotmodel it may be chosen over the suggestedparentTypebecause it's a subclass ofVm.Bug-Url: https://bugzilla.redhat.com/2080728