Allow setting virtual NUMA nodes without host pinning #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
sgratch,
ljelinkova,
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
|
/ost |
ljelinkova
reviewed
May 31, 2022
...on/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Show resolved
Hide resolved
Of course I did when I set the |
Hmm, it probably works because of the following lines: I am not a big fan of how the logic for NUMA is scattered throughout the code. Anyway, sorry I've doubted you :-) (no really, there are so many different paths that can be tested in the VM dialog that it is easy to miss some of them). |
ljelinkova
approved these changes
Jun 1, 2022
ahadas
reviewed
Jun 2, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java
Show resolved
Hide resolved
This patch will allow setting via UI and API virtual NUMA nodes to a VM without having the VM pinned to a host. If a `numa_node_pin` is set, the scheduler will filter out hosts that won't fit to the NUMA pinning. Otherwise, the VM will start with the set amount of virtual NUMA nodes. Change-Id: Ia35a95babf3ae6b2d4713c809052be1d6ddede38 Bug-Url: https://bugzilla.redhat.com/2081410 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
|
/ost |
1 similar comment
|
/ost |
ahadas
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will allow setting via UI and API virtual NUMA nodes to a VM
without having the VM pinned to a host. If a
numa_node_pinis set, thescheduler will filter out hosts that won't fit to the NUMA pinning.
Otherwise, the VM will start with the set amount of virtual NUMA nodes.
Change-Id: Ia35a95babf3ae6b2d4713c809052be1d6ddede38
Bug-Url: https://bugzilla.redhat.com/2081410
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com