Don't use vdsm core for isolate threads #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
ljelinkova
reviewed
Jun 8, 2022
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
ahadas
reviewed
Jun 9, 2022
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
ljelinkova
reviewed
Jun 9, 2022
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
|
/ost |
|
/ost |
ahadas
approved these changes
Jun 13, 2022
ljelinkova
approved these changes
Jun 14, 2022
When allocating CPUs for isolate threads we use the maximum freed socket. We get all the non-pinned CPUs for this socket. The problem is that later on we don't filter out cores with pinned CPUs. Now we return all the CPUs in the socket and that way, when we iterate the cores, we are able to filter out those with pinned CPUs. Change-Id: Ic81d93ecd830cea689a8eea4579d6e728c5b2e04 Bug-Url: https://bugzilla.redhat.com/2094415 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When allocating CPUs for isolate threads we use the maximum freed
socket. This socket is already without pinned CPUs. With that, isolate
threads thinks these cores are free to use, while they are not.
This patch changes the maximum freed socket to contain every CPU within
it, without dropping taken CPUs.
Change-Id: Ic81d93ecd830cea689a8eea4579d6e728c5b2e04
Bug-Url: https://bugzilla.redhat.com/2094415
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com