Ansible: gluster-brick-create switch from community modules to commands #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barpavel
approved these changes
Feb 14, 2022
| | cache_lvname | yes | | | Name of the Logical Volume to be used for cache. | ||
| | cache_lvsize | yes | | | Size of the cache logical volume | ||
| | mntpath | yes | | | Path to mount the filesystem. | ||
| | pool_metadatasize | yes | | | Size of the pools metadata, should be between 2M to 16G (Example: 24M). |
There was a problem hiding this comment.
Just make sure it' shouldn't be 2MiB & 16GiB.
|
Verified the patch on my setup working as expected. |
|
/ost |
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change to the gluster-brick-create ansible role. The main change is that we switched from community modules which are no longer supported to the commands. We need this change for possible ansible-core support.
Along with the changes, I have bit improved the readme and ansible lint for better readability.
I was able to test these changes on my server with multiple reruns and looked fine, but I was not able to test it with gluster.
Bug-Url: https://bugzilla.redhat.com/2052690