Ansible-runner: Fix getting status of playbook #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnecas
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
mnecas
force-pushed
the
fix_ansible_polling_status
branch
2 times, most recently
from
3b0cafe
to
428f6be
Compare
liranr23
reviewed
Jun 15, 2022
...odules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerClient.java
Show resolved
Hide resolved
Ansible-runner command does nolonger create status file when running but only after it finished. This patch changes the logic to return status running acording to daemon.log which is created right after the playbook is started.
mnecas
force-pushed
the
fix_ansible_polling_status
branch
from
428f6be
to
1c91e52
Compare
|
/ost |
liranr23
approved these changes
Jun 15, 2022
|
@michalskrivanek / @mwperina can we get it in? |
mwperina
approved these changes
Jun 16, 2022
ahadas
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible-runner command no longer creates a status file when running but
only after it is finished. This patch changes the logic to return status
running according to daemon.log which is created right after the playbook
is started. Before this PR, the status of the playbook was always unknow
so when doing the pooling it always passed and continued until it either
succeeded, failed, or timed out.