core: Check for real FIPS when adding username to a VNC ticket #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIPS can be enabled on a host without the corresponding parameter in the kernel command line. In such a case, the host expects username in the VNC display ticket. But Engine inserts username only when the FIPS parameter is in the kernel command line and VNC connection doesn’t work is such a case. To fix this, let’s check in Engine for what the host says about FIPS rather than for the kernel command line parameter.
mz-pdm
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
nyoxi
approved these changes
Jun 17, 2022
|
/ost |
|
meh, "qemu-kvm: Unable to generate DH parameters: Error in public key generation.". I've seen it before...maybe no enough entropy or something? eh... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIPS can be enabled on a host without the corresponding parameter in
the kernel command line. In such a case, the host expects username in
the VNC display ticket. But Engine inserts username only when the
FIPS parameter is in the kernel command line and VNC connection
doesn’t work is such a case.
To fix this, let’s check in Engine for what the host says about FIPS
rather than for the kernel command line parameter.