core: Block MBS Image upload #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
reviewed
Jun 20, 2022
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
|
Suggestion use a validation similar to And once transfer is supported (shouldn't be too hard to do) we can just enable it in Regarding commit message and PR description: both upload and download are blocked, so I'd rephrase it to "transfer" |
bennyz
reviewed
Jun 20, 2022
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2077649
branch
3 times, most recently
from
0dd0868
to
8366d64
Compare
ArtiomDivak
requested review from
barpavel,
aesteve-rh,
mkemel,
rokkbert and
sleviim
bennyz
reviewed
Jun 22, 2022
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
bennyz
reviewed
Jun 22, 2022
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
barpavel
reviewed
Jun 23, 2022
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Show resolved
Hide resolved
bennyz
reviewed
Jun 23, 2022
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Show resolved
Hide resolved
bennyz
reviewed
Jun 27, 2022
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
sleviim
suggested changes
Jun 27, 2022
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
|
/ost |
2 similar comments
|
/ost |
|
/ost |
|
/ost |
1 similar comment
|
/ost |
ahadas
reviewed
Jul 7, 2022
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
Transfering image into MBS will be block inside TransferDiskImageCommand validation Signed-off-by: Artiom Divak <adivak@redhat.com>
|
/ost |
4 similar comments
|
/ost |
|
/ost |
|
/ost |
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading image into MBS will be block inside TransferDiskImageCommand validation
Signed-off-by: Artiom Divak adivak@redhat.com