webadmin: Refactor NUMA for VM #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for the review - next run configuration for NUMA will be fixed in a separate PR. |
liranr23
reviewed
Jun 27, 2022
...monweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
Outdated
Show resolved
Hide resolved
...dmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
Outdated
Show resolved
Hide resolved
ljelinkova
requested review from
oliel,
mwperina,
bennyz,
emesika,
michalskrivanek and
didib
as code owners
With recent changes in the VM NUMA area the behavior of the NUMA count and the NUMA support button was not consistent and sometimes the changes were not saved on the backend at all. This patch refactors the source code so that: - The numaEnabled field has been removed from the UnitVmModel because after the recent changes only the NUMA support button was affected by its value. Instead, we enable and disable directly the NUMA support action. - the NUMA support was renamed to NUMA pinning (in the code, not UI message) as we now enable NUMA by setting the numaCount - the updateNuma parameter sent to the backend is now calculated in the behaviors. For the new VM, it is sent if the numa count > 0. For existing VMs, there is a series of checks to determine if the NUMA should be updated on the backend. As a result, the initialVmNumaNodes has been moved from UnitVmModel to the ExistingVmModelBehavior because that is the only place where it is used. - added support from configuring NUMA when creating a new VM from a template page Bug-Url: https://bugzilla.redhat.com/2099225
|
/ost |
ahadas
reviewed
Jun 28, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Show resolved
Hide resolved
...dmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
Outdated
Show resolved
Hide resolved
...les/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
Outdated
Show resolved
Hide resolved
...onweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/NumaUnitToVmBaseBuilder.java
Show resolved
Hide resolved
...icommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Show resolved
Hide resolved
When updating a VM, it was required to send updateNuma parameter that determined if the numa node changes will be saved. The UI had to handle the logic which started to be quite complicated - the numa nodes changes with memory, cpu, hugepages, numa count, numa pinning, numa tune mode change. This patch adds the possibility to leave out that parameter and in that case the new numa node list is compared to the one in the database. If they differ, the new numa node list will be saved.
liranr23
reviewed
Jun 29, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Show resolved
Hide resolved
liranr23
approved these changes
Jun 29, 2022
|
/ost |
ahadas
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent changes in the VM NUMA area the behavior of the NUMA count and the NUMA support button was not consistent and sometimes the changes were not saved on the backend at all.
This patch refactors the source code so that:
Bug-Url: https://bugzilla.redhat.com/2099225