Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: Fix NPE when misconfiguring NUMA with hugepages #500

Merged
merged 1 commit into from Jun 27, 2022
Merged

engine: Fix NPE when misconfiguring NUMA with hugepages #500

merged 1 commit into from Jun 27, 2022

Conversation

ljelinkova
Copy link
Collaborator

@ljelinkova ljelinkova commented Jun 27, 2022 •
edited by ahadas

When a VM with NUMA is set with hugepages with a size that is different than the one reported by the host, the
running of the VM fails with NPE in NumaPinningHelper.

This patch fixes the NPE.

@ljelinkova
engine: Fix NPE when misconfiguring NUMA with hugepages
0167b38 
When a VM with NUMA is set with a hugepages with a size
that is different than the one reported by the host, the
running of the VM fails with NPE in NumaPinningHelper.

This patch fixes the NPE.
@ljelinkova ljelinkova requested a review from liranr23 June 27, 2022 12:09
@liranr23
Copy link
Member

When a VM with NUMA is set with a hugepages with a size that is different than the one reported by the host, the running of the VM fails with NPE in NumaPinningHelper.

This patch fixes the NPE.

and the VM still fail to run, right? :)

@ljelinkova
Copy link
Collaborator Author

When a VM with NUMA is set with a hugepages with a size that is different than the one reported by the host, the running of the VM fails with NPE in NumaPinningHelper.
This patch fixes the NPE.

and the VM still fail to run, right? :)

Yes :-) But this time with a proper message:
The host host-8-5 did not satisfy internal filter NUMA because cannot accommodate memory of VM's pinned virtual NUMA nodes within host's physical NUMA nodes..

@ahadas ahadas merged commit b4aa257 into oVirt:master Jun 27, 2022
@ljelinkova ljelinkova deleted the numa-hugepages branch June 29, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

@liranr23 liranr23 liranr23 approved these changes

@bennyz bennyz Awaiting requested review from bennyz bennyz is a code owner

@emesika emesika Awaiting requested review from emesika emesika is a code owner

@mwperina mwperina Awaiting requested review from mwperina mwperina is a code owner

@michalskrivanek michalskrivanek Awaiting requested review from michalskrivanek michalskrivanek is a code owner

@oliel oliel Awaiting requested review from oliel oliel is a code owner

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

@didib didib Awaiting requested review from didib didib is a code owner

Assignees
No one assigned
Labels
verified virt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ljelinkova @liranr23 @ahadas