Set VMs that preview memory snapshots to suspended #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
requested review from
sgratch,
ljelinkova,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
ahadas
changed the title
|
/ost |
smelamud
approved these changes
Jul 7, 2022
liranr23
reviewed
Jul 11, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Show resolved
Hide resolved
liranr23
approved these changes
Jul 11, 2022
ljelinkova
reviewed
Jul 12, 2022
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
If the VMs are set to restore memory, we would now set them to Suspended status so they'll be treated as VMs that were hibernated (e.g., create next-run snapshots when their configuration changes) Bug-Url: https://bugzilla.redhat.com/1257644 Signed-off-by: Arik Hadas <ahadas@redhat.com>
you meant the first one, in which IsMemorySnapshotSupported is dropped, right? added an explanation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the VMs are set to restore memory, we would now set them to
Suspended status so they'll be treated as VMs that were hibernated
(e.g., create next-run snapshots when their configuration changes)
Bug-Url: https://bugzilla.redhat.com/1257644