core: Report names rather than ids in affinity conflicts #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mz-pdm
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
didib and
ljelinkova
as code owners
|
It works but I need to get rid of NullPointerException's in tests. |
|
Tests fixed. |
ljelinkova
reviewed
Jul 22, 2022
...manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/AffinityValidator.java
Show resolved
Hide resolved
...src/test/java/org/ovirt/engine/core/bll/scheduling/commands/AddAffinityGroupCommandTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/ovirt/engine/core/bll/scheduling/commands/AddAffinityGroupCommandTest.java
Outdated
Show resolved
Hide resolved
|
Good catches, less code is always good :-), thanks, fixed. |
ljelinkova
reviewed
Jul 22, 2022
...manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/AffinityValidator.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/ovirt/engine/core/bll/scheduling/commands/EditAffinityGroupCommandTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/ovirt/engine/core/bll/scheduling/commands/EditAffinityGroupCommandTest.java
Outdated
Show resolved
Hide resolved
ljelinkova
approved these changes
Jul 22, 2022
|
/ost |
ahadas
approved these changes
Jul 24, 2022
When an affinity conflict occurs, the hosts or VMs participating in the conflict are reported by their ids. This is accurate but not very user friendly, especially in the web UI dialog. Let’s report the conflicting entities by their names instead. We must retrieve the names from the corresponding DAOs. In theory, AffinityGroup’s should contain entity names corresponding to the ids, but this doesn’t hold and the names are often missing there. Due to the DAO access, AffinityValidator.checkAffinityGroupConflicts can no longer be static. And because AffinityValidator is a singleton, it cannot be used in tests as it is (AFAICT). That means we have to mock AffinityValidator.checkAffinityGroupConflicts in some tests and give up on testing that method there. Bug-Url: https://bugzilla.redhat.com/1991622
smelamud
approved these changes
Jul 24, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an affinity conflict occurs, the hosts or VMs participating in
the conflict are reported by their ids. This is accurate but not very
user friendly, especially in the web UI dialog. Let’s report the
conflicting entities by their names instead.
We must retrieve the names from the corresponding DAOs. In theory,
AffinityGroup’s should contain entity names corresponding to the ids,
but this doesn’t hold and the names are often missing there.
Due to the DAO access, AffinityValidator.checkAffinityGroupConflicts
can no longer be static. And because AffinityValidator is a
singleton, it cannot be used in tests as it is (AFAICT). That means
we have to mock AffinityValidator.checkAffinityGroupConflicts in some
tests and give up on testing that method there.
Bug-Url: https://bugzilla.redhat.com/1991622