ci: Checkout the PR head, not the github merge commit #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjd78
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
didib and
ljelinkova
as code owners
didib
approved these changes
Jul 21, 2022
Between that thread going on for awhile and my work on #541, this PR's tweak seemed appropriate. |
In the CI github action, checkout the PR head commit instead of the `actions/checkout@v2` default of the PR merge commit. The practical effect of this change is the exported artifacts snapshot suffix will contain the commit id of the last commit on the PR instead of the magic github generated merge commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CI github action, checkout the PR head commit instead of the
actions/checkout@v2default of the PR merge commit. The practicaleffect of this change is the exported artifacts snapshot suffix will
contain the commit id of the last commit on the PR instead of the
magic github generated merge commit.