Ansible runner cleanup #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tinez
commented
Jul 21, 2022
tinez
commented
- ansible: Remove unused things
- AnsibleRunnerClient: make 'mapper' a scoped object
tinez
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
didib and
ljelinkova
as code owners
|
/ost |
mnecas
reviewed
Jul 22, 2022
| @@ -188,7 +179,6 @@ public int processEvents(String playUuid, | |||
| } | |||
| } | |||
| lastEvent = event; | |||
| returnValue.setLastEventId(getLastEventId()); | |||
| lastEventId++; | |||
| } | |||
| return lastEvent.isEmpty() ? lastEventId : getLastEventId(); | |||
There was a problem hiding this comment.
Yes, while I was going over the code trying to wrap my head around it I noticed some things that are unused. This one is not enough to fix the problem. Now rebased on top of Michal's changes.
None of the removed things are used: - we never do anything with neither 'msg' nor 'logFile' arguments of 'AnsibleRunnerClient.processEvents' - the 'AnsibleReturnValue' instance created in 'AnsibleCallback.doPolling' is used only locally and doesn't affect the logic
tinez
force-pushed
the
ansible-runner-cleanup
branch
from
060d482
to
25cbbef
Compare
|
/ost |
michalskrivanek
approved these changes
Jul 28, 2022
mwperina
reviewed
Jul 28, 2022
| .builder() | ||
| .findAndAddModules() | ||
| .build() | ||
| .configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false); |
There was a problem hiding this comment.
What's so harmful on having JsonMapper shared between threads? Unless I'm missing something we use that approach a lot in engine, because JsonMapper initialization takes some time ...
There was a problem hiding this comment.
Right, I thought sharing the mapper between threads might be an issue, but found in the docs: Mapper instances are fully thread-safe provided that ALL configuration of the instance occurs before ANY read or write calls. Thanks!
tinez
force-pushed
the
ansible-runner-cleanup
branch
from
25cbbef
to
5dcc52f
Compare
michalskrivanek
requested changes
Jul 28, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AnsibleCallback.java
Show resolved
Hide resolved
michalskrivanek
approved these changes
Jul 28, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.