engine: fix reboot on powering up VM #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the VM was powering UP and had the next run configuration, the cold reboot did not work. It had several reasons that have been fixed in this patch: 1. the VM was just cleared based on getVmManager().getPowerOffTimeout() 2. the VmAnalyzer:proceedDisappearedVm did not have RebootInProgress case and the default one was executed. However, the code never reached the setColdRebootFlag() as the VM was listed as asyncRunning and scheduled for rerun. 3. the next run config was never applied as the VM was present in asyncRunning and never added to movedDown list. Bug-Url: https://bugzilla.redhat.com/1912911
ljelinkova
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
|
/ost |
mz-pdm
reviewed
Jul 26, 2022
| case PoweringDown: | ||
| if (getVmManager().isColdReboot()) { | ||
| setColdRebootFlag(); | ||
| resourceManager.removeAsyncRunningVm(dbVm.getId()); |
There was a problem hiding this comment.
Wondering what's the purpose of managing the "async running" VMs and what the VM removal from it here influences.
There was a problem hiding this comment.
If I understand correctly, if a VM is in asyncRunningVms list, it means that the VM was just started, began migration or resuming. If such a VM goes down, it will be rerun. Otherwise, if the VM is not in asyncRunningVms list, it means that the VM was expected to go down and it should not be rerun.
There was a problem hiding this comment.
I see, thank you for clarification. Then it indeed has its purpose here.
ahadas
reviewed
Jul 27, 2022
...r/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
Show resolved
Hide resolved
ahadas
approved these changes
Jul 28, 2022
...r/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the VM was powering UP and had the next run configuration, the cold reboot did not work. It had several reasons that have been fixed in this patch:
getVmManager().getPowerOffTimeout()VmAnalyzer:proceedDisappearedVmdid not haveRebootInProgresscase and the default one was executed.However, the code never reached the
setColdRebootFlag()as the VM was listed asasyncRunningand scheduled for rerun.asyncRunningand never added tomovedDownlist.Bug-Url: https://bugzilla.redhat.com/1912911