core: Prevent writing TPM device twice to OVA #578
Conversation
TPM device has its own method writing its OVF entry. But as a special device, it’s written the second time to OVF among other devices. When such an OVF is imported, the VM has two TPM devices, which is not allowed by libvirt and the VM fails to start. This patch prevents writing the second TPM device entry to OVF. Bug-Url: https://bugzilla.redhat.com/2112702
mz-pdm
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
|
@mz-pdm so why keeping TPM as a "special device"? |
|
@smelamud that explains why it was added but if we write it elsewhere (not as "other" device) and here we add special handling, then the question is why keep considering it a special device? we can also read it as TPM and not "other" device |
|
it's definitely a device we care about :) but why is it special? the criteria for being "special" in that context is that we write and read it as a general device, without unique or device-specific properties, and so we can use the general method for it. but as we have a specific method for writing it, we can also use a TPM-specific method for reading it and won't consider it special anymore no? the current state is a bit confusing |
|
Let's move the discussion to #582 . |
TPM device has its own method writing its OVF entry. But as a special
device, it’s written the second time to OVF among other devices. When
such an OVF is imported, the VM has two TPM devices, which is not
allowed by libvirt and the VM fails to start.
This patch prevents writing the second TPM device entry to OVF.
Bug-Url: https://bugzilla.redhat.com/2112702