LiveMerge: move getVolumeInfo to executeCommand #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barpavel
approved these changes
Aug 9, 2022
...l/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java
Show resolved
Hide resolved
mkemel
force-pushed
the
fix_remove_snapshot_with_merged_image
branch
from
31d4581
to
14e2efc
Compare
ahadas
approved these changes
Aug 16, 2022
Call to GetVolumeInfo was added to RemoveSnapshotSingleDiskLive command before performing the steps, in order to check if the Destination image (or the Top Image) exists on storage. It was added to the procedure, which is determining the initial merge step during the first run of performNextOperation. GetVolumeInfo is a synchronous call, and calling it from performNextOperation can block the callback thread which may block other commands from making progress. This change moves the procedure of setting the initial merge step back to executeCommand(), like it is in ColdMergeSnapshotSingleDisk command
ahadas
force-pushed
the
fix_remove_snapshot_with_merged_image
branch
from
14e2efc
to
b776cd3
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call to GetVolumeInfo was added to RemoveSnapshotSingleDiskLive
command before performing the steps, in order to check if the
Destination image (or the Top Image) exists on storage. It was added
to the procedure, which is determining the initial merge step during
the first run of performNextOperation.
GetVolumeInfo is a synchronous call, and calling it from
performNextOperation can block the callback thread which may block
other commands from making progress. This change moves the procedure
of setting the initial merge step back to executeCommand(), like it
is in ColdMergeSnapshotSingleDisk command