Commits on Aug 18, 2022

1. packaging: setup: Always use formerly-engine-specific PostgreSql conf …

   We currently have two sets of configuration items for PG: One is common
   to all DBs, another is specific to the engine. Unite them, by moving the
   engine-specific set to the common one.
   
   Cases where this is relevant:
   
   1. Right now, 'engine-backup --mode=restore --provision-all-databases'
   does not configure the engine-specific items. This causes a next run of
   'engine-setup' (which is mandatory) to prompt, asking whether to
   configure them.
   
   2. Trying to pre-create DBs using provisiondb, like I am now trying [1],
   leaves postgresql.conf without the engine-specific set. This is worse
   than in (1.), as the code prompting/asking works only with non-new
   databases. It's not a real issue for [1] specifically, because I can
   easily do this there, but decided it's better to patch engine-setup
   directly.
   
   This has no impact on the common case, where all DBs are local, as this
   configuration is PG-cluster-wide, not DB-specific.
   
   The main impact is on DWH running on a separate machine, with the
   database local to that machine. If the DWH DB is remote, our
   documentation already instructs to configure all items, not separating
   to two sets.
   
   [1] oVirt/ovirt-system-tests#241
   
   Change-Id: Ief318aa5551cec2d778cf791926518effe404da2
   Signed-off-by: Yedidyah Bar David <didi@redhat.com>

   

   didib committed Aug 18, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 8ec3b64
   • Browse repository at this point

   Copy the full SHA

   8ec3b64 View commit details

   Browse the repository at this point in the history