core: Remove image if CreateSnapshotFromTemplateCommand failed #609
Conversation
In some scenarios CreateSnapshotFromTemplateCommand fails after creation of the record in the images table. In this case the record should be removed together with other DB records related to the disk. Change-Id: I201b49b9acd052c733c4d418abbac3b16c9431d5 Bug-Url: https://bugzilla.redhat.com/2110351 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
| @@ -89,6 +92,9 @@ protected void endWithFailure() { | |||
| if (diskImageDynamicDao.get(getDestinationDiskImage().getImageId()) != null) { | |||
| diskImageDynamicDao.remove(getDestinationDiskImage().getImageId()); | |||
| } | |||
| if (imageDao.get(getDestinationDiskImage().getImageId()) != null) { | |||
There was a problem hiding this comment.
will it answer on some of the comment above? should you check if it succeed before removing as written?
There was a problem hiding this comment.
No, it won't. The comment says about checking the result of RemoveImageCommand before removing the records from the database. This is a completely different task and I doubt we should implement it this way. dbOperationScope parameter of RemoveImageCommand should rather be used, I think.
But this patch just adds a removal of one more record that refers the disk. This record does not usually exist when CreateSnapshotFromTemplateCommand fails, but in this particular case (after failure of SealVmCommand) it exists and should be removed when the disk is removed, just like records in any other table.
There was a problem hiding this comment.
OK, although i do think it might be better to insert into the remove image command. but, since we already have other DB removals like that (baseDiskDao and diskImageDynamicDao)...
In some scenarios CreateSnapshotFromTemplateCommand fails after creation
of the record in the images table. In this case the record should be
removed together with other DB records related to the disk.
Change-Id: I201b49b9acd052c733c4d418abbac3b16c9431d5
Bug-Url: https://bugzilla.redhat.com/2110351
Signed-off-by: Shmuel Melamud smelamud@redhat.com