core: Allow RunOnce for single non-bootable disk #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a VM contains a single disk not marked as bootable, RunVmCommand allows to boot OS from this disk. But RunOnce ignores this disk when setting the boot order. This patch fixes this inconsistence. Change-Id: Ia5652bb1549bdd5205284be355e3a2903fb6e9f1 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
smelamud
requested review from
sgratch,
ljelinkova,
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
ljelinkova
approved these changes
Aug 29, 2022
mz-pdm
approved these changes
Aug 31, 2022
ahadas
reviewed
Aug 31, 2022
...ger/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
Show resolved
Hide resolved
ahadas
approved these changes
Sep 1, 2022
...ger/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a VM contains a single disk not marked as bootable, RunVmCommand
allows to boot OS from this disk. But RunOnce ignores this disk when
setting the boot order. This patch fixes this inconsistence.
Change-Id: Ia5652bb1549bdd5205284be355e3a2903fb6e9f1
Signed-off-by: Shmuel Melamud smelamud@redhat.com