core: fail unmonitored backups #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
force-pushed
the
fail-unmonitored-backups
branch
from
b507068
to
bf2db55
Compare
bennyz
requested review from
ahadas,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
bennyz
force-pushed
the
fail-unmonitored-backups
branch
from
bf2db55
to
4c9382d
Compare
ahadas
reviewed
Aug 25, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/DbEntityCleanupManager.java
Outdated
Show resolved
Hide resolved
bennyz
force-pushed
the
fail-unmonitored-backups
branch
2 times, most recently
from
fb8f6a9
to
0d433ab
Compare
|
/ost |
ahadas
reviewed
Aug 25, 2022
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Outdated
Show resolved
Hide resolved
ahadas
approved these changes
Aug 25, 2022
ahadas
changed the title
|
/ost |
1 similar comment
|
/ost |
If the command monitoring a VM backup is no longer present in the command_entities table, it will be impossible to finalize the backup and it will be stuck in the finalizing phase. This patch checks periodically for backups that are active but are no longer monitored and fails them, notifying the user a cleanup may be required. Bug-Url: https://bugzilla.redhat.com/2107590 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
…gMessages.properties
bennyz
force-pushed
the
fail-unmonitored-backups
branch
from
335d61e
to
d6f56b9
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the command monitoring a VM backup is no longer present in the command_entities table, it will be impossible to finalize the backup and it will be stuck in the finalizing phase.
This patch checks periodically for backups that are active but are no longer monitored and fails them, notifying the user a cleanup may be required.
Bug-Url: https://bugzilla.redhat.com/2107590