core: do not use DeserializationFeature.READ_ENUMS_USING_TO_STRING #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
commented
Sep 1, 2022
.../src/main/java/org/ovirt/engine/core/common/businessentities/storage/TransferClientType.java
Outdated
Show resolved
Hide resolved
bennyz
force-pushed
the
fix-client-type-paramter-restore
branch
from
8d72e8c
to
0f54790
Compare
|
/ost |
bennyz
force-pushed
the
fix-client-type-paramter-restore
branch
from
0f54790
to
9dea759
Compare
ahadas
reviewed
Sep 4, 2022
.../src/main/java/org/ovirt/engine/core/common/businessentities/storage/TransferClientType.java
Outdated
Show resolved
Hide resolved
bennyz
force-pushed
the
fix-client-type-paramter-restore
branch
from
9dea759
to
5fc7d21
Compare
bennyz
requested review from
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
bennyz
force-pushed
the
fix-client-type-paramter-restore
branch
3 times, most recently
from
c97ecc6
to
1997fd4
Compare
|
/ost |
ahadas
reviewed
Sep 6, 2022
ahadas
approved these changes
Sep 6, 2022
bennyz
force-pushed
the
fix-client-type-paramter-restore
branch
from
1997fd4
to
429b3e6
Compare
bennyz
changed the title
bennyz
force-pushed
the
fix-client-type-paramter-restore
branch
from
429b3e6
to
9e8828a
Compare
bennyz
force-pushed
the
fix-client-type-paramter-restore
branch
from
9e8828a
to
a483226
Compare
|
lgtm (already approved) |
|
/ost |
DeserializationFeature.READ_ENUMS_USING_TO_STRING causes jackson to deserialize enums using their toString implementation, however, this implementation may have been overridden to returns a value that does not match Enum#name(), causing deserialization to fail. Because of this it would make more sense to use the default, which uses Enum#name() as it is less likely to be overridden. Additionally, the corresponding serialization config (WRITE_ENUMS_USING_TO_STRING), which will make jackson use different methods for serialization and deserialization. Bug-Url: https://bugzilla.redhat.com/2123008 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
mwperina
force-pushed
the
fix-client-type-paramter-restore
branch
from
a483226
to
ff78ae0
Compare
barpavel
approved these changes
Sep 8, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeserializationFeature.READ_ENUMS_USING_TO_STRING causes jackson to
deserialize enums using their toString implementation, however, this
implementation may have been overridden to returns a value that does not
match Enum#name(), causing deserialization to fail. Because of this it
would make more sense to use the default, which uses Enum#name() as it
is cannot be overridden.
Additionally, the corresponding serialization config
(WRITE_ENUMS_USING_TO_STRING), which will make jackson use different
methods for serialization and deserialization.
Bug-Url: https://bugzilla.redhat.com/2123008