core: Refresh ISO cache when new guest agent installed #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelamud
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
didib and
ljelinkova
as code owners
mz-pdm
reviewed
Sep 9, 2022
| @@ -746,7 +746,9 @@ private void updateRuntimeData() { | |||
| vmGuestAgentNics = filterGuestAgentInterfaces(nullToEmptyList(vdsmVm.getVmGuestAgentInterfaces())); | |||
| dbVm.setIp(extractVmIps(vmGuestAgentNics)); | |||
| } | |||
|
|
|||
| if (!Objects.equals(vdsmVm.getVmDynamic().getAppList(), dbVm.getAppList())) { | |||
| resourceManager.refreshIsoCache(vdsManager.getCopyVds().getStoragePoolId()); | |||
There was a problem hiding this comment.
Do we need to call getCopyVds() just to get the storage pool id?
There was a problem hiding this comment.
Yes, AFAIK. There is no other place where the storage pool ID is stored.
smelamud
force-pushed
the
bug-1983401
branch
from
f10fd98
to
f6a0374
Compare
|
Updated the description in the commit message with more details. |
|
/ost |
The latest available guest tools version is figured out by analyzing ISO disks available on ISO and data storage domains. The list of available ISO disks is cached and this cache is refreshed when user queries the list of images on a storage domain. At that moment, the latest guest tools version is refreshed and the guest agent installation hint (presented to the user) is updated. But ISO cache refresh does not happen after a new guest agent is installed. That's why the guest agent installation hint is still shown after installing the latest guest agent in the VM. To fix that, this patch adds ISO cache refresh when the list of applications for a particular VM is changed. Change-Id: I6c25a97ae14cc40d073b3873c6bae9db3216204d Bug-Url: https://bugzilla.redhat.com/1983401 Bug-Url: https://bugzilla.redhat.com/2120381 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
mwperina
force-pushed
the
bug-1983401
branch
from
f6a0374
to
674da65
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest available guest tools version is figured out by analyzing ISO
disks available on ISO and data storage domains. The list of available
ISO disks is cached and this cache is refreshed when user queries the
list of images on a storage domain. At that moment, the latest guest
tools version is refreshed and the guest agent installation hint
(presented to the user) is updated.
But ISO cache refresh does not happen after a new guest agent is
installed. That's why the guest agent installation hint is still shown
after installing the latest guest agent in the VM.
To fix that, this patch adds ISO cache refresh when the list of
applications for a particular VM is changed.
Change-Id: I6c25a97ae14cc40d073b3873c6bae9db3216204d
Bug-Url: https://bugzilla.redhat.com/1983401
Bug-Url: https://bugzilla.redhat.com/2120381
Signed-off-by: Shmuel Melamud smelamud@redhat.com