packaging: setup: remote_engine: manual_files: Read as binary #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didib
added a commit
to didib/ovirt-dwh
that referenced
this pull request
Sep 8, 2022
This reverts commit 40b2df1. I think that patch was merged to fix a bug in manual_files, but broke root_ssh. [2] is an alternative, which should make both work. [2] oVirt/ovirt-engine#645
Make remote_engine_manual_files.py match the behavior of remote_engine_root_ssh.py, and so make 'copy_from_engine' return a bytes object, not str. This should fix the bug that [1] was supposed to fix, but [1] only fixed it for the 'manual files' mode and broke paramiko/ssh. [1] oVirt/ovirt-dwh@885d65f Change-Id: I32cd8aff5e851fb053b2cd5b8237455ce2230a35 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
force-pushed
the
remote-engine-manual-files-return-bytes
branch
from
0a1e228
to
2c64f53
Compare
mwperina
pushed a commit
to oVirt/ovirt-dwh
that referenced
this pull request
Sep 20, 2022
This reverts commit 40b2df1. I think that patch was merged to fix a bug in manual_files, but broke root_ssh. [2] is an alternative, which should make both work. [2] oVirt/ovirt-engine#645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make remote_engine_manual_files.py match the behavior of remote_engine_root_ssh.py, and so make 'copy_from_engine' return a bytes object, not str.
This should fix the bug that [1] was supposed to fix, but [1] only fixed it for the 'manual files' mode and broke paramiko/ssh.
[1]
oVirt/ovirt-dwh@885d65f
Change-Id: I32cd8aff5e851fb053b2cd5b8237455ce2230a35
Signed-off-by: Yedidyah Bar David didi@redhat.com