restapi: Use cpuPinningPolicy from template #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBH I was not aware that we copy the values here. I think we might have missed even more properties - could you please check if cpuPinning string and parallel migrations work correctly? |
Include cpuPinningPolicy, cpuPinning, parallelMigrations fields when extracting data from a VM template for creating a VM through REST API. Fixes oVirt#633 Change-Id: I139d3c9c00a005610eebe172272a45b3f37ace27 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
|
@ljelinkova You've been right - these fields were also missing. Updated the patch. |
ljelinkova
approved these changes
Sep 15, 2022
mz-pdm
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include cpuPinningPolicy when extracting data from a VM template for creating a VM through REST API.
Fixes #633
Change-Id: I139d3c9c00a005610eebe172272a45b3f37ace27
Signed-off-by: Shmuel Melamud smelamud@redhat.com