Removing a duplicate "setStoragePoolId()" call at the "LiveMigrateDiskCommand" class #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exactly the same call to "setStoragePoolId()" is already performed in "init()", see [1]. So I see no reason why the same code should be executed again in "validate()", especially that "validate()" is designed for other purposes. [1] https://github.com/oVirt/ovirt-engine/blob/ovirt-engine-4.5.2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java#L143 Signed-off-by: Pavel Bar <pbar@redhat.com>
|
This PR is not blocking any other PR, this is just a suggestion, something I noticed while working on another bug :) |
|
/ost |
ahadas
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly the same call to
setStoragePoolId()is already performed ininit(), see [1].So I see no reason why the same code should be executed again in
validate(), especially thatvalidate()is designed for other purposes.[1] https://github.com/oVirt/ovirt-engine/blob/ovirt-engine-4.5.2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java#L143
Signed-off-by: Pavel Bar pbar@redhat.com