engine: Fix update cluster with numa VMs #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing a cluster's CPU or version, an update of the underlying VMs and templates is performed. If any of them has numa enabled, the update cluster command would fail because paramters's updateNuma = null is changed to updateNuma = true in UpdateVmCommand. Tnis patch makes it explicit that we are not updating the numa by setting updateNuma = false parameter.
ljelinkova
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud and
didib
as code owners
|
/ost |
smelamud
approved these changes
Sep 21, 2022
mz-pdm
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a cluster's CPU or version, an update of the underlying VMs and templates is performed.
If any of them has numa enabled, the update cluster command would fail because paramters's updateNuma = null is changed to updateNuma = true in UpdateVmCommand.
Tnis patch makes it explicit that we are not updating the numa by setting updateNuma = false parameter.