Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix checking if an active snapshot is set with memory for restoring purpose #667

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

sgratch
Copy link
Member

@sgratch sgratch commented Sep 21, 2022

This is a followup fix for #653 (based on a comment review ) by including the metadata volumes (in addition to memory ones) when checking if an active snapshot is set with memory for restoring.

Signed-off-by: Sharon Gratch sgratch@redhat.com

…ring purpose

This is a followup fix for
oVirt#653 (based on a comment review).
by including the metadata volumes (in addition to memory ones) when checking if
an active snapshot is set with memory for restoring.
@sgratch
Copy link
Member Author

sgratch commented Sep 21, 2022

/ost

Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message makes it sounds as if there is a functional benefit in doing that - and there shouldn't be, but in terms of readability it's a bit better, thanks for posting this @sgratch

@ahadas ahadas merged commit 315f18d into oVirt:master Sep 21, 2022
@sgratch sgratch deleted the restore_memory_small_fix branch September 21, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants