core: use fips-compatible padding for provider passwords #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use OAEP with SHA256 and MGF1 padding in password encryption and decryption during authenticating with ovirt-ovn-provieder on el9 deployments where FIPS is enabled. This change should not be merged until all code paths using the modified EngineEncryptionUtils facility are evaluated for correctness and until this modification is made active only when FIPS is enabled. Signed-off-by: Eitan Raviv <eraviv@redhat.com> Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com> Change-Id: Ie895d2249716d6aafd64d79ae2d61083181b9703
tinez
requested review from
didib,
sandrobonazzola,
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud and
ljelinkova
as code owners
|
/ost basic-suite-master el9stream |
michalskrivanek
requested changes
Sep 27, 2022
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py
Outdated
Show resolved
Hide resolved
|
/ost basic-suite-master el9stream |
michalskrivanek
changed the title
michalskrivanek
approved these changes
Sep 27, 2022
mwperina
added a commit
to mwperina/ovirt-engine
that referenced
this pull request
Sep 27, 2022
We have added new encryption/decryption method for OVN provider password as a part of oVirt#677 Unfortunately there was an error during password decryptio due to the implementation differencies between Python and OpenJDK. Signed-off-by: Martin Perina <mperina@redhat.com>
michalskrivanek
added a commit
that referenced
this pull request
Sep 27, 2022
* Fix padding issue when decrypting OVN provider password We have added new encryption/decryption method for OVN provider password as a part of #677 Unfortunately there was an error during password decryptio due to the implementation differences between Python and OpenJDK. Signed-off-by: Martin Perina <mperina@redhat.com> Co-authored-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OAEP with SHA256 and MGF1 padding in password encryption and
decryption during authenticating with ovirt-ovn-provieder on el9
deployments where FIPS is enabled.
This change should not be merged until all code paths using the modified
EngineEncryptionUtils facility are evaluated for correctness and until
this modification is made active only when FIPS is enabled.
Signed-off-by: Eitan Raviv eraviv@redhat.com
Signed-off-by: Marcin Sobczyk msobczyk@redhat.com
Change-Id: Ie895d2249716d6aafd64d79ae2d61083181b9703