Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: fix cbs el9 build issue #700

Merged
merged 2 commits into from Oct 5, 2022
Merged

backport: fix cbs el9 build issue #700

merged 2 commits into from Oct 5, 2022

Conversation

mwperina
Copy link
Member

@mwperina mwperina commented Oct 5, 2022 •
edited

  • Skip validation of build environment
  • Increase GWT localWorkers to 2

@mwperina
Skip validation of build environment
42144cf 
We are checking maximum number of available file descriptors when
building engine for all support permutations. But in CBS this validation
doesn't work because maximum number of available file descriptors is not
reported properly. And we are also limiting number of workers for GWT
build, so we don't get near this limit.

Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina
Increase GWT localWorkers to 2
1ea1b56 
Having 2 localWorkers for GWT build decreases compilation time
significantly and it doesn't exceed available resources in CBS.

Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina mwperina force-pushed the fix-cbs-el9-build-issue-4.5.3 branch from f693f37 to 1ea1b56 Compare October 5, 2022 07:13
@mwperina mwperina merged commit 116ed20 into oVirt:ovirt-engine-4.5.3.z Oct 5, 2022
@mwperina mwperina deleted the fix-cbs-el9-build-issue-4.5.3 branch October 5, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalskrivanek michalskrivanek michalskrivanek approved these changes

@didib didib Awaiting requested review from didib didib is a code owner

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

@ahadas ahadas Awaiting requested review from ahadas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mwperina @michalskrivanek