Issue: Incorrect Data Center for the "Upload Image" dialog #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sermakov-orion
commented
Feb 19, 2024
...commonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
Show resolved
Hide resolved
sermakov-orion
commented
Feb 19, 2024
...commonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
Show resolved
Hide resolved
sermakov-orion
commented
Feb 19, 2024
...commonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
Show resolved
Hide resolved
sermakov-orion
commented
Feb 19, 2024
...commonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
Show resolved
Hide resolved
sermakov-orion
changed the title
|
Requesting Reviews. |
barpavel
reviewed
Apr 22, 2024
...commonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
Outdated
Show resolved
Hide resolved
Comment on lines
192
to
193
| getDataCenter().getItemsChangedEvent() | ||
| .addListener((ev, sender, args) -> selectDataCenter(dcId)); |
There was a problem hiding this comment.
If the above selectDataCenter(dcId); (line 190) succeeded, still need to add this listener?
If so , the Or in the above comments is confusing.
There was a problem hiding this comment.
@barpavel
In general, the initial version works with no issues. But I agree - in some cases, when "the above selectDataCenter(dcId); (line 190) succeeded" then there is no need to configure the listener.
So, I refactored the code and adjusted the comments. Please take a look.
There was a problem hiding this comment.
Thanks, looks good.
Just a few style issues to keep consistency:
- Please update the comments both above these lines and at the
selectDataCenter()method to have a space between the//and the comment text itself. - [Optional] Lines 227-228 in many places the style is to have
.stream()`
.filter(...)
.findFirst()
but that's really up to you.
...commonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stepan Ermakov <sermakov@orionsoft.ru>
This PR fixes the following issue: incorrect Data Center is displayed when uploading a disk image from "Storage Domain Disks" UI.
Steps to reproduce:
1. Create a Storage Domain at non-Default Data Center.
2. Open the Storage -> Domains -> <The created Storage Domain> -> Disks page.
3. Select the Upload -> Start menu item. The "Upload image" dialog is displayed.
Expected behavior:
The Data Center filed is disabled and displays the name of the non-Default Data Center.
Current behavior:
The Data Center field is disabled and display the name of the Default Data Center.
Fixed in the following way: when "Upload image" dialog is displayed then query the Storage Domain details with information about its Data Center and select the Storage Domain's Data Center in the "Data Center" field
sermakov-orion
force-pushed
the
disk_upload_data_center
branch
from
58256c2
to
d5fba38
Compare
|
LGTM. |
sandrobonazzola
requested review from
dupondje and
BrooklynDewolf
and removed request for
ljelinkova
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Ermakov sermakov@orionsoft.ru
Changes introduced with this PR
This PR fixes the following issue: incorrect Data Center is displayed when uploading a disk image from "Storage Domain Disks" UI.
Steps to reproduce:
1. Create a Storage Domain at a non-Default Data Center.
2. Open the Storage -> Domains -> [The created Storage Domain] -> Disks page.
3. Select the Upload -> Start menu item. The "Upload image" dialog is displayed.
Expected behavior:
The Data Center field is disabled and displays the name of the non-Default Data Center.
Current behavior:
The Data Center field is disabled and displays the name of the Default Data Center.
Fixed in the following way: when "Upload image" dialog is displayed then query the Storage Domain details with information about its Data Center and select the Storage Domain's Data Center in the "Data Center" field
Are you the owner of the code you are sending in, or do you have permission of the owner?
y